[melodic-devel] Windows bringup

ros-perception / openslam_gmapping

218 stars 206 forks source link

[melodic-devel] Windows bringup #34

Closed seanyen closed 2 years ago

seanyen commented 4 years ago

Follow catkin guide to install libraries and executables to portable locations. https://docs.ros.org/api/catkin/html/howto/format1/building_libraries.html#installing https://docs.ros.org/api/catkin/html/howto/format1/building_executables.html#installing
Replace GCC-specific __PRETTY_FUNCTION__ with C++11 standard __func__.
Adding visibility control, which is required to create shared libraries on Windows, by using CMake GenerateExportHeader convention.
Conditionally guard many Linux\POSIX-only header inclusion with #ifndef _WIN32.

This change is verified to build with http://wiki.ros.org/Installation/Windows.

seanyen commented 4 years ago

@k-okada This is ready for review. Let me know any feedback. Thanks!

seanyen commented 3 years ago

@k-okada Friendly ping.

Tobias-Fischer commented 2 years ago

Friendly ping @k-okada - it would be great to see this merged!

k-okada commented 2 years ago

@seanyen @Tobias-Fischer BTW, if you know how to configure CI for Windows, please let me know. I am pretty sure that someone will brake the Windows build in future, because most of people only compile on their Ubuntu machine.

Tobias-Fischer commented 2 years ago

Hi, in moveit we setup a cross-platform CI (Linux+OSX+Win) using the Robostack project. It's just around adding to simple files that run a GitHub action: https://github.com/ros-planning/moveit/blob/master/.github/workflows/cross_platform_ci.yml and https://github.com/ros-planning/moveit/blob/master/.github/ci_cross_platform_env.yml

/cc @wolfv @traversaro

k-okada commented 2 years ago

@Tobias-Fischer great, @seanyen could you create windows script to compile openslam_gmapping ?