search

ros-perception / openslam_gmapping

218 stars 206 forks source link

Add RoboStack CI #40

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

As discussed in https://github.com/ros-perception/openslam_gmapping/pull/34 this aims to provide cross-platform (Win, MacOS and Linux) integration.

@wolfv @traversaro - do you have any idea why the builds are not being triggered? Are there some changes needed to enable GitHub actions in the repo first?

Tobias-Fischer commented 2 years ago

Okay, all fixed now.

@k-okada this is ready for review. You can see an an example run here. Once merged in, this will run in the melodic-devel branch as well as on pull requests.

k-okada commented 2 years ago

@Tobias-Fischer great!. It worked as expected, https://github.com/k-okada/openslam_gmapping/actions/runs/1306534586. 

  push:
    branches:
      - master
      - "[kmn]*-devel"
      - patch-2 <<<<<<<<<<<<<< should we remove this?
Tobias-Fischer commented 2 years ago

Done.

k-okada commented 2 years ago

@Tobias-Fischer thank you!

wolfv commented 2 years ago

Awesome!