ros-perception / openslam_gmapping

218 stars 206 forks source link

Fixed for enable compilation on windows #9

Closed nicolapiccinelli closed 8 years ago

nicolapiccinelli commented 9 years ago

Hi, i've found some issue during the compilation of gmapping under Windows with visual c++ 2013. The problem comes due to the usage of functions and definition not present in the c++ standard library. I've fix the problem adding a preprocessor ifdef for give an equivalent define.

wjwwood commented 9 years ago

+1, with comments. Don't have time to try it.

vrabaud commented 9 years ago

@nicolapiccinelli , any news on that ?

nicolapiccinelli commented 9 years ago

I look at you commit but you had define only srand48 and you miss the declaration of drand48 used in line 38 and over. I will give a try to these fixes on windows?

vrabaud commented 9 years ago

Right, that's what my other comments were saying: srand48, not need for it anymore, drand48 is already defined for windows in include/gmapping/utils/gvalues.h so you should include that header wherever you have a compile problem, lrand48 was unused.

nicolapiccinelli commented 9 years ago

I will test it on Monday. We need to check pretty_function definition?

vrabaud commented 9 years ago

in the end, your patch should just be to pretty function and a proper include of include/gmapping/utils/gvalues.h wherever it does nto compile.

nicolapiccinelli commented 9 years ago

Ok i will try and notice.

vrabaud commented 9 years ago

any news on that ?

vrabaud commented 9 years ago

@nicolapiccinelli , up.

vrabaud commented 8 years ago

closing in favor of a1f451b

wtc1993 commented 8 years ago

Can you share your version of gmapping on windows? I also want to learn it.

nicolapiccinelli commented 7 years ago

I'm a bit in late :) but my porting was intended to integrate gmapping in Matlab via mexfile. You can give a look to the repository here inside the algorithms folder.