search

ros-perception / pcl_conversions

[deprecated] pcl_conversions has moved to https://github.com/ros-perception/perception_pcl
10 stars 26 forks source link

Copyright information #11

Closed mikeferguson closed 10 years ago

mikeferguson commented 10 years ago

@wjwwood What is the legacy of this code? My understanding is that these functions were copied in from PCL code that was removed, correct? If so, shouldn't the copyright retain "2010-2012 Willow Garage" in the line right below "2013 Open Source Robotics Foundation"?

wjwwood commented 10 years ago

The code was definitely inspired by the PCL code, but mostly it is new code.

Some parts where copied from ROS and modified, other parts were copied from PCL and modified.

It would probably be accurate to include the copyright WG, but mostly because of inspiration and copy and then modify. I don't think any of it is just copied without changes.

mikeferguson commented 10 years ago

@wjwwood, how would you want to handle code that is completely copied in from PCL? I'd like to open a pull request to import this function: https://github.com/mikeferguson/chessbox/blob/hydro-devel/chess_perception/include/chess_perception/conversions.h#L48 which I find I use a lot when subscribing to a point cloud and then wanting an image as well. Would you be ok with me adding the 2010-2012 WG line in the copyright header when adding that function?

wjwwood commented 10 years ago

I'm totally fine with that.

wjwwood commented 10 years ago

Can we close this?

mikeferguson commented 10 years ago

Yes we can.