Closed tobiasneumann closed 1 year ago
I think this should be split up into PRs of different natures or else this will never get merged since we'll nitpick the different additions at the same time. The changes to the units, sensor properties, and adding offsets are all different subjects.
This PR proposes several changed to the
RadarReturn
andRadarScan
messages.Summary
Time stamp
The current message for a
RadarScan
just stores one time stamp for all returns. And this time stamp is not clearly defined.Proposed change
stamp_offset
toRadarReturn
, which will be used relatively to the time stamp of the time stamp in the fieldheader
ofRadarScan
.header
ofRadarScan
to be of the first return.Usage of the spherical angles
The current description for the
azimuth
andelevation
angles doesn't directly specify the order of these angles. From the comment forelevation
"For 2D radar, this will be 0." the order can be deducted, but it could be clearer.Proposed change
Missing Measurement characteristics
While for LiDAR sensors the measured returns are typically treated as points, this behavior is problematic for radar sensors.
Proposed change
sensor_properties
toRadarScan
SensorProperties
to group the information about the device used for the measurement.Missing definition of amplitude
The description for the field
amplitude
is missing the relative information of the measurement.Proposed change