ros-perception / radar_msgs

A set of standard messages for RADARs in ROS
Apache License 2.0
25 stars 5 forks source link

Adapt RadarReturn and RadarScan #14

Closed tobiasneumann closed 1 year ago

tobiasneumann commented 1 year ago

This PR proposes several changed to the RadarReturn and RadarScan messages.

Summary

Time stamp

The current message for a RadarScan just stores one time stamp for all returns. And this time stamp is not clearly defined.

Proposed change

Usage of the spherical angles

The current description for the azimuth and elevation angles doesn't directly specify the order of these angles. From the comment for elevation "For 2D radar, this will be 0." the order can be deducted, but it could be clearer.

Proposed change

Missing Measurement characteristics

While for LiDAR sensors the measured returns are typically treated as points, this behavior is problematic for radar sensors.

Proposed change

Missing definition of amplitude

The description for the field amplitude is missing the relative information of the measurement.

Proposed change

SteveMacenski commented 1 year ago

I think this should be split up into PRs of different natures or else this will never get merged since we'll nitpick the different additions at the same time. The changes to the units, sensor properties, and adding offsets are all different subjects.

tobiasneumann commented 1 year ago

It is now split into