switch to tf2 - Githubissues

ros-perception / slam_gmapping

http://www.ros.org/wiki/slam_gmapping

657 stars 528 forks source link

switch to tf2 #31

Open vrabaud opened 9 years ago

vrabaud commented 9 years ago

@tfoote , @wjwwood , if you have a few minutes to check that. Tests pass. Thx

wjwwood commented 9 years ago

Looks fine to me, but @tfoote should really review it, he's more familiar with the tf specific changes than me.

tfoote commented 9 years ago

Reading through it it looks reasonable. I opened an enhancement ticket to duplicate the getYaw method from tf. But you shouldn't wait for that.

vrabaud commented 9 years ago

thx ! With all the tf2 conversions I've done, the only thing that could not be done simply is indeed the getYaw function (navigation uses it a lot). Will follow up on https://github.com/ros/geometry_experimental/issues/110

allenh1 commented 7 years ago

@vrabaud Is there any reason that this didn't ever get merged?

vrabaud commented 7 years ago

@tfoote, can you please review ? Also, tests now run slower, is that to be expected from tf2 ? Thx