ros-perception / slam_gmapping

http://www.ros.org/wiki/slam_gmapping
656 stars 528 forks source link

ROS Melodic release #72

Closed airballking closed 1 year ago

airballking commented 5 years ago

I was looking for this package on ROS Melodic. What are the plans for releasing it?

k-okada commented 5 years ago

@mikaelarguedas can we release this as a part of http://wiki.ros.org/OrphanedPackage initiative?

mikaelarguedas commented 5 years ago

@k-okada I am not a maintainer here, I just happened to have made the Lunar release of this repo. This looks like a good candidate for the Orphaned Packages initiative.

Friendly ping @vrabaud, are you ok for allowing the Orphaned Packages maintainer team to release this repo?

k-okada commented 5 years ago

We have been contacting @vrabaud for long time including https://github.com/ros-perception/openslam_gmapping/pull/20#issuecomment-442481968 and personal e-mail, but could not get any response from him. Can someone (@wjwwood ?) give access to slam_gmapping and openslam_gmapping repository?

wjwwood commented 5 years ago

@k-okada I invited you to the @ros-perception/gmapping team.

k-okada commented 5 years ago

@wjwwood sorry for late, but I have released in to melodic with BSD-3 version (https://github.com/ros/rosdistro/pull/21711) Could you also set melodic-devel branch as a default branch of https://github.com/ros-perception/openslam_gmapping repository ?

It still missing a1f451b Vincent Rabaud better Windows compilation This is taken from #9 which can now be closed. 24ebb35 Vincent Rabaud disable GUI It should not have been enable in the first place bb1b839 Vincent Rabaud fix a few more graphics stuff for Qt5 0b893e4 Vincent Rabaud get GUI back in shape 012ec4e Vincent Rabaud use srand instead of srand48 srand48 is non-standard and we are using a seed that is an unsigned int so we might as well use srand

wjwwood commented 5 years ago

Could you also set melodic-devel branch as a default branch of https://github.com/ros-perception/openslam_gmapping repository ?

Done.

k-okada commented 5 years ago

@wjwwood Thanks. could you also set melodic-devel as a default branch for https://github.com/ros-perception/openslam_gmapping too? (c.f. https://github.com/ros/rosdistro/pull/21746)

wjwwood commented 5 years ago

That's what I already did...

k-okada commented 5 years ago

sorry please change at https://github.com/ros-perception/slam_gmapping, not https://github.com/ros-perception/openslam_gmapping 2019年7月13日(土) 2:27 William Woodall notifications@github.com:

That's what I already did...

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ros-perception/slam_gmapping/issues/72?email_source=notifications&email_token=AADYNXBOX6V2OYOVAMJENWTP7C5F7A5CNFSM4G4VLU2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2L7XI#issuecomment-510967773, or mute the thread https://github.com/notifications/unsubscribe-auth/AADYNXF7YOA53NQDKOBKXTTP7C5F7ANCNFSM4G4VLU2A .

--

◉ Kei Okada

wjwwood commented 5 years ago

Ah, got you. It's done.

AchmadFathoni commented 5 years ago

I can't find gmapping nor openslam in my apt package list for melodic. Am I missing something?

k-okada commented 5 years ago

they will be available on next sync, maybe July 30th -> https://discourse.ros.org/t/preparing-for-melodic-sync-2019-07-22/10016

◉ Kei Okada

2019年7月27日(土) 3:32 Achmad Fathoni notifications@github.com:

I can't find gmapping nor openslam in my apt package list for melodic. Am I missing something?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-perception/slam_gmapping/issues/72?email_source=notifications&email_token=AADYNXFVYWL4NLB5JDADHP3QBM7KXA5CNFSM4G4VLU2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25MEWI#issuecomment-515555929, or mute the thread https://github.com/notifications/unsubscribe-auth/AADYNXCDUGEEICUADFAVU4TQBM7KXANCNFSM4G4VLU2A .

AchmadFathoni commented 5 years ago

It is available for melodic now, thanks for all the hard work @k-okada .