search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
155 stars 74 forks source link

Edited Code, the typoes #16

Closed harderthan closed 5 years ago

harderthan commented 5 years ago

For understanding clearly, I edited some remarks. The expert can understand those without any remarks. But, someone maybe be going to be confused.

Please check this. Thanks.

harderthan commented 5 years ago

I re-sent a pull-request. I edited typoes and parameters for the test functions.

Kukanani commented 5 years ago

The original version of the tests pass. However in this case you have changed the expected results of the tests, but the underlying code remains the same, so the new tests will fail. If you want to add clarifying parentheses, I'll happily merge that, but as-is this PR will break the build.

The actual calculation is not (left + width)/2, it's left + (width/2), which is equivalent to left + width/2 using the standard order of operations. See the implementation.

mintar commented 5 years ago

I agree that everything was correct before, so no part of this PR should be merged.

harderthan commented 5 years ago

Um.. now, I understood. I thought those are a couple of X, Y points of the bounding box. Then, these remarks don't need parentheses like left + (width/2). Sorry about misunderstanding. Thanks.