search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
155 stars 74 forks source link

add tracking ID to the Detection Message #19

Closed hakuturu583 closed 5 years ago

hakuturu583 commented 5 years ago

I want to add tracking infomation I described in this Issue.

18

hakuturu583 commented 5 years ago

Does anyone check this PR?

Kukanani commented 5 years ago

After further reflection (and as pointed out in #17), I think a string would be a more flexible representation to use. A string could be used to store a UUID if desired (using any UUID generator), but wouldn't require additional dependencies from everyone who wants to use this feature.

mistermult commented 5 years ago

After further reflection (and as pointed out in #17), I think a string would be a more flexible representation to use. A string could be used to store a UUID if desired (using any UUID generator), but wouldn't require additional dependencies from everyone who wants to use this feature.

A string needs more overhead because the length has to be saved etc. We should use the same type for id and tracking_id. Both are foreign keys into a collection of classes/objects. So both of them should be int64 or both of them should be strings.

Using strings for classes is even better: This would make is easy to just enter the class name without lookup, enter WikiData IDs, e.g. Q470112, or URLs (keyword: linked data).

hakuturu583 commented 5 years ago

@mintar Do you think how to treat same class objects at the same scene??

Kukanani commented 5 years ago

I've switched the tracking_id field to a string to avoid the UUID dependency. Of course, if you'd like, you can still store a string representation of the UUID, but this is more flexible.

Thanks for the PR!

hakuturu583 commented 5 years ago

@Kukanani Please revert this commit(https://github.com/Kukanani/vision_msgs/pull/19/commits/3a38cddd10da41ce9945f6bea7d7ab3dac3a3b0f) and retrun to UUID description. Let's discuss in #18

hakuturu583 commented 5 years ago

@Kukanani Flexible representation shold not be used in designing ROS modules. It causes problem while connecting modules.