search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
155 stars 74 forks source link

[WIP] rviz display plugin #29

Closed LeroyR closed 3 years ago

LeroyR commented 5 years ago

Wip rviz display.

image

Kukanani commented 3 years ago

Do you plan do continue work on this plugin? If I don't hear back in a week, I will close this due to inactivity

LeroyR commented 3 years ago

For implementation it may be that pointclouds are not displayed. If rviz has a "visual" class for points its a quick change, but (without checking) I would bet that its integrated in the point display so we must either fix this upstream or copy some code from rviz/point_cloud_display.

Question is if you want this here as it can break on rviz changes, so it creates extra maintenance cost.

Also, this changes the repo layout so it may need changes to CI.

I dont really know how this should be setup so it "just works" - you dont want to depend on this package anywhere so no one installs/finds this if they just install the msgs. Maybe could add this to the ros-desktop metapkg then?

Kukanani commented 3 years ago

Thanks for laying this out. Rather than changing the whole repo structure and adding more packages and dependencies, I'd encourage you to create this as a separate GitHub repository. If you do, I can link to it from the README for this package so others can find it easily (even if you don't plan on releasing the package to the ROS repositories).

I'm going to close this, but feel free to respond if there are any follow-ups.