ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
155 stars 74 forks source link

revert breaking changes to Kinetic branch #33

Closed Kukanani closed 4 years ago

Kukanani commented 4 years ago

Reverting to avoid breaking backward compatibility.

@mistermult @hakuturu583 to continue using the changes from PRs #22 and #19, please switch to the master (development) branch.

hakuturu583 commented 4 years ago

I could not understand why this makes breaking change.

Kukanani commented 4 years ago

Changing a message field type (#22) will break workflows of anyone who uses that field, causing build errors on C++ and possibly runtime errors on Python.

Adding fields (#19) can cause issues with mismatched MD5 sums. Example: https://answers.ros.org/question/10628/running-processes-on-different-machines-causes-md5sum-incompatibility-issue/ Open Robotics rarely updates their message definitions for a given ROS distro (or even between them) to avoid breaking interoperability for this reason.