search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
155 stars 74 forks source link

Changed D to d #6

Closed Kukanani closed 7 years ago

Kukanani commented 7 years ago

See 2.3 of http://wiki.ros.org/ROS/Patterns/Conventions.

This change improves ROS2 compatibility. Because of how ROS2 message headers are generated, the following behavior arises:

Detection3DArray.msg -> vision_msgs/msg/detection3_d_array.hpp
Detection3dArray.msg -> vision_msgs/msg/detection3d_array.hpp

The second line makes more sense and is preferable.

Note: Legacy messages such as geometry_msgs/Pose2D only use a capital D to ensure backwards-compatibility.

Kukanani commented 7 years ago

After talking with people at OSRF, it's probably best to stick with convention, despite the awkward include.