search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
160 stars 75 forks source link

replace deprecated pose2d with pose #64

Closed ijnek closed 2 years ago

ijnek commented 2 years ago

Pose2D is deprecated in geometry_msgs, so use Pose. Alternative would be to have x, y, theta as fields of BoundingBox2d.msg and not depend on geometry_msgs/Pose2D.

Resolves: #65

SteveMacenski commented 2 years ago

This seems perfectly reasonable. However, I'd like to hold off until I re-engage with folks on https://github.com/ros2/common_interfaces/issues/179 to see if we can't keep the message around.

ijnek commented 2 years ago

@SteveMacenski updated accordingly.

SteveMacenski commented 2 years ago

@Kukanani do you want to take a look