search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
149 stars 72 forks source link

Galactic BoundingBox3DArray message not generated for Python #68

Closed vinnnyr closed 2 years ago

vinnnyr commented 2 years ago

In Galactic, BoundingBox3DArray does not show up as a generated message for python, for neither the apt binary, nor when building from source:

>>> from vision_msgs.msg import BoundingBox3DArray
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'BoundingBox3DArray' from 'vision_msgs.msg'

This occurs in a fresh docker container too, and could be replicated there: https://asciinema.org/a/vtbiRQtrlSXIvhR25SM7cMLS7

If you look at the __init__.py for the message (for binary located here: /opt/ros/galactic/lib/python3.8/site-packages/vision_msgs/msg/__init__.py) you can see that the message is not generated. I am not sure why that may be yet.

from vision_msgs.msg._bounding_box2_d import BoundingBox2D  # noqa: F401
from vision_msgs.msg._bounding_box3_d import BoundingBox3D  # noqa: F401
from vision_msgs.msg._classification import Classification  # noqa: F401
from vision_msgs.msg._detection2_d import Detection2D  # noqa: F401
from vision_msgs.msg._detection2_d_array import Detection2DArray  # noqa: F401
from vision_msgs.msg._detection3_d import Detection3D  # noqa: F401
from vision_msgs.msg._detection3_d_array import Detection3DArray  # noqa: F401
from vision_msgs.msg._object_hypothesis import ObjectHypothesis  # noqa: F401
from vision_msgs.msg._object_hypothesis_with_pose import ObjectHypothesisWithPose  # noqa: F401
from vision_msgs.msg._vision_info import VisionInfo  # noqa: F401
vinnnyr commented 2 years ago

Ok nevermind, I realize what happened. That message is present in the ros2 branch, but not the galactic branch, and therefore I guess it won't be released for galactic.

vinnnyr commented 2 years ago

well maybe I can re-open this issue just to ask -- can it be cherry-picked onto the galactic branch / released for the next galactic sync, or does it break some sort of rule?

Kukanani commented 2 years ago

Actually, the file does exist in galactic, but it's not in the CMakeLists.txt message files list. Or at least, it wasn't, until I just pushed it a few minutes ago. Now visible here.

Kukanani commented 2 years ago

Please let me know if this works for you and we can create another release.

And just FYI, my policy (which I believe is standard for most ROS message packages) is to not make any changes to existing messages on a given distro (because this will change md5sums), but adding new messages is no problem.

vinnnyr commented 2 years ago

yes this works for me now -- thank you!

Kukanani commented 2 years ago

new release created (3.0.2), PR here: https://github.com/ros/rosdistro/pull/32488

gbr1 commented 1 year ago

Hi! It seems this issue is present also in foxy.

I'm not able to use BoundingBox2DArray and BoundingBox3DArray. Thank you.

gbr1 commented 1 year ago

Just made a PR https://github.com/ros-perception/vision_msgs/pull/73