ObjectHypothesisWithPose with label

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.

Apache License 2.0

160 stars 75 forks source link

ObjectHypothesisWithPose with label #76

Open gbr1 opened 2 years ago

gbr1 commented 2 years ago

Hi, I'm working on wrapping edgeimpulse on ROS2.

It could be useful to have a string label parameter in the message type ObjectHypothesisWithPose because it often happen that you want to send also the label.

What do you think about that?

Thank you in advance!

gbr1 commented 2 years ago

I found another issue:

id in ObjectHypothesisWithPose is numeric (int64) for noetic but for foxy is a string
in galactic ObjectHypothesis is used instead

Please can you make unified? Thank you in advance

SteveMacenski commented 2 years ago

That change was intentional

gbr1 commented 2 years ago

@SteveMacenski so should be foxy updated to the galactic message version (the one with ObjectHypothesis)?

Kukanani commented 2 years ago

We don't usually unify message definitions across distros unless there is a very strong reason to do so. Because ROS messages are very brittle (non-identical message definitions cause all kinds of headaches), making breaking changes usually only happens between distros.

Future distros will all have ObjectHypothesis (unless another new change comes in), which allows a string. foxy will always have a string, noetic will always have an int.