ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
149 stars 72 forks source link

Added rviz plugins #79

Closed NovoG93 closed 1 year ago

NovoG93 commented 1 year ago

To keep the vision_msgs package agnostic I added a meta package and moved initial vision_msgs package

SteveMacenski commented 1 year ago

Thanks @NovoG93 for the work and great gifs / demos! This will be very nice to have out of the box. I'll plan on releasing this at the end of next week in my previously scheduled release cycle!

SteveMacenski commented 1 year ago

You may want to post on ROS Discourse about this (with your gif!) for visibility

NovoG93 commented 1 year ago

Glad it finally worked out! Will post on ROS Discourse once it is released.

SteveMacenski commented 1 year ago

@NovoG93 We have some build failures that will stop me from running binaries until we have them resolved. I was planning on syncing this on Friday so if you could patch up things today, tomorrow or Thursday we can keep on track

12:32:59 In file included from /tmp/ws/build_isolated/vision_msgs_rviz_plugins/include/vision_msgs_rviz_plugins/../../../../src/vision_msgs/vision_msgs_rviz_plugins/include/vision_msgs_rviz_plugins/detection_3d_array.hpp:33,
12:32:59                  from /tmp/ws/build_isolated/vision_msgs_rviz_plugins/include/vision_msgs_rviz_plugins/moc_detection_3d_array.cpp:9:
12:32:59 /tmp/ws/src/vision_msgs/vision_msgs_rviz_plugins/include/vision_msgs_rviz_plugins/detection_3d_common.hpp: In member function ‘void rviz_plugins::Detection3DCommon<MessageType>::updateColorConfig()’:
12:32:59 /tmp/ws/src/vision_msgs/vision_msgs_rviz_plugins/include/vision_msgs_rviz_plugins/detection_3d_common.hpp:488:20: error: ‘rcpputils::fs’ has not been declared
12:32:59   488 |     if (rcpputils::fs::exists(tmp_path)) {
12:32:59       |                    ^~
12:32:59 make[2]: *** [CMakeFiles/vision_msgs_rviz_plugins.dir/build.make:113: CMakeFiles/vision_msgs_rviz_plugins.dir/include/vision_msgs_rviz_plugins/moc_detection_3d_array.cpp.o] Error 1

https://build.ros2.org/job/Fdev__vision_msgs__ubuntu_focal_amd64/18/console

At the very least, that package isn't linked against or included in the package.xml

NovoG93 commented 1 year ago

@SteveMacenski will look into that now

NovoG93 commented 1 year ago

@SteveMacenski I just noticed that the jenkins build job is running on Ubuntu20.04 with Foxy. Will the vision_msgs be migrated from humble to foxy as they are different (e.g. Detection3D). The rviz plugin in the PR is only compatible with the vision_msgs definition of Humble, for Foxy I only implemented a small part of the Humble capabilities (https://github.com/NovoG93/vision_msgs_rviz_plugins/tree/foxy) however this code was not included in the PR.

Besides the rcpputils::fs problem there was a problem with the QT Meta-Object Compiler on the common headers that is also fixed with the latest commit.
For testing I used the docker images ros:rolling-ros-core-jammy, ros:humble-ros-core-jammy, and ros:foxy-ros-core-focal and built the package using: . /opt/ros/$ROS_DISTRO/setup.sh && PYTHONIOENCODING=utf_8 PYTHONUNBUFFERED=1 colcon build --build-base build_isolated --install-base install_isolated --test-result-base test_results --event-handlers console_cohesion+ --cmake-args -DBUILD_TESTING=0 as it is apparently executed in the jenkins build job

I created a new PR for that here: https://github.com/ros-perception/vision_msgs/pull/84

SteveMacenski commented 1 year ago

It is actually released to Humble, Rolling, etc. The foxy job is just the one that's failing currently.