search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
160 stars 75 forks source link

Validate BoundingBox3D message #85

Closed MarqRazz closed 1 year ago

MarqRazz commented 1 year ago

I have been working on testing the ground truth system of Isaac sim and have found some issues with their publishers of vision_msgs data. They are working on improving this tool, but while talking with their engineers they pointed me to a case where one dimension of the BoundingBox3D message can be set to zero. That is if a flat plane mesh is in the scene, the 3d bbox will have zero thickness. In this PR I have submitted a suggestion on how the Rviz plugin can support this.

SteveMacenski commented 1 year ago

LGTM other than adding brackets to your if/else statements. Check CI results as well - you have linting issues causing it to fail that need to be fixed too

MarqRazz commented 1 year ago

Sorry about the formatting errors, I've obviously been spoiled with pre-commit on most of my repos.