ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
160 stars 75 forks source link

Replace Pose2D with geometry_msgs/msg/Pose2D #90

Closed sloretz closed 1 year ago

sloretz commented 1 year ago

It looks like vision_msgs/msg/Pose2D and geometry_msgs/msg/Pose2D are identical, or at least they were before https://github.com/ros-perception/vision_msgs/pull/67 split it into Point2D and Pose2D (where Point2D is used only by Pose2D).

I propose removing Point2D and Pose2D from this repo and using geometry_msgs/msg/Pose2D instead.

SteveMacenski commented 1 year ago

The depreciation notice in Geometry Messages is why its not used. I've been advocating against its eventual removal for some time now due to things like this (among others). If that planned removal is withheld, then I'd be more than happy to use the geometry_msgs version.

https://github.com/ros-perception/vision_msgs/pull/64

mintar commented 1 year ago

These two messages are not semantically identical, so they have to stay separate: