search

ros-perception / vision_msgs

Algorithm-agnostic computer vision message types for ROS.
Apache License 2.0
149 stars 72 forks source link

Utilize vision_msgs/Point2D in BoundingBox2D #91

Closed hyunseok-yang closed 1 year ago

hyunseok-yang commented 1 year ago

I'd like to use geometry_msgs/Point2D(?) or vision_msgs/Size2D(?) hopefully if it exists. (I know there does not exist)

But, I think this is more intutive and matched a consistency with BoundingBox3D,

SteveMacenski commented 1 year ago

Are there any others we should also update like this?

hyunseok-yang commented 1 year ago

Are there any others we should also update like this?

I guess that's all :)

mintar commented 1 year ago

I don't think this is an improvement. Point2D specifies an absolute position in pixels, but the size of the bounding box is a length. Strictly speaking, you cannot add two points, but you can add a point and a length, or two lengths.

One solution would be to add a vision_msgs/Size2D, like @hyunseok-yang already suggested, but is it really worth it?

SteveMacenski commented 1 year ago

+1 on @mintar I didn't look close enough