search

ros-perception / vision_opencv

Apache License 2.0
536 stars 599 forks source link

Address RHEL buildfailure with Boost 1.66.0 #495

Closed ijnek closed 1 year ago

ijnek commented 1 year ago

Fixes a problem introduced in https://github.com/ros-perception/vision_opencv/pull/489/files, when boost version is 1.66 (ie. on RHEL).

python3 should be the correct component used from Boost, not python.

ijnek commented 1 year ago

@Mergifyio backport foxy

mergify[bot] commented 1 year ago

backport foxy

✅ Backports have been created

* [#496 Address RHEL buildfailure with Boost 1.66.0 (backport #495)](https://github.com/ros-perception/vision_opencv/pull/496) has been created for branch `foxy`
ijnek commented 1 year ago

The COMPONENTS keyword could be used, but shouldn't be necessary in this case. Thanks for the review, going to check what the CI failure is now.

ijnek commented 1 year ago

CI failure was due to

Boost_VERSION returns "1.71.0" with CMake version newer than 3.15, whereas in CMake versions before 3.15, it returned "107100". See CMP0093 for more. So, with the current condition:

if(Boost_VERSION LESS 106700)

Evaluates True for all values of Boost_VERSION. This should be changed to 

if(Boost_VERSION_STRING VERSION_LESS "1.67")

which should evaluate it correctly.