search

ros-planning / navigation_msgs

Message packages required by the navigation stack
42 stars 53 forks source link

Bump CMake version to avoid CMP0048 #13

Closed sloretz closed 4 years ago

sloretz commented 4 years ago

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

ros/catkin#1052

SteveMacenski commented 4 years ago

@mikeferguson shouldn’t this have been targeted to ros1?

mikeferguson commented 4 years ago

I cherry-picked this to ros1 just now, and reverted the jade-devel changes

mikeferguson commented 4 years ago

I'm also updating readmes so it's clear what branches are supported where

SteveMacenski commented 4 years ago

Makes sense. I would also personally like the ros2 branch to be default. Since this is the very last time we're going to be releasing them (probably) it would be good to have a changing of the defaults.

Also, I just like to push the ROS2 agenda. So I'm biased.