search

ros-planning / navigation_msgs

Message packages required by the navigation stack
42 stars 53 forks source link

[ros2] Update maintainers #23

Closed mabelzhang closed 3 years ago

mabelzhang commented 3 years ago

Signed-off-by: Mabel Zhang mabel@openrobotics.org

SteveMacenski commented 3 years ago

Should you just delete move_base_msgs? Move base doesn't exist anymore and Navigation2 has no dependencies on it

mabelzhang commented 3 years ago

Just noticed the other PR. Will close this one.

mabelzhang commented 3 years ago

Actually I'll just leave out the update in that package and keep the other change.

mikeferguson commented 3 years ago

As a note - the ROS1 branch of this repo is still maintained by the ROS1 navigation team (@Dlu and myself). I don't think we need additional help from Open Robotics (I know you folks are spread pretty thin on a bunch of packages).

The ROS2 branch I'm not really involved in at this time - but honestly, I think @SteveMacenski and the ROS2 nav team should probably be maintainers until messages get upstreamed into nav_msgs some day and the ROS2 branch could die off.

mabelzhang commented 3 years ago

@SteveMacenski do you want to be added to the maintainers for map_msgs?

Just for context, we are adding an Open Robotics employee to all the repositories checked out in the ROS 2 core build, because we can't do a release without releasing the packages. map_msgs is used by rviz_default_plugins https://github.com/ros2/rviz/blob/ros2/rviz_default_plugins/CMakeLists.txt#L64 , so we'd like to have an OR employee on the maintainer list. I believe there's no one from OR on the ROS 2 nav team, so it'd be whoever that wants to + 1 from OR.

SteveMacenski commented 3 years ago

Sure, why not.

mabelzhang commented 3 years ago

Are we good to merge?