search

ros-safety / software_watchdogs

A library of (software) watchdogs based on DDS Quality of Service (QoS) policies and ROS 2 lifecycle nodes.
Apache License 2.0
71 stars 17 forks source link

Migrate github action to rolling #10

Closed norro closed 3 years ago

norro commented 3 years ago
norro commented 3 years ago

This is in preparation of adding launch tests. @robbel @gbiggs can you have a look? I somehow don't have permissions to request a review.

I guess that we want to create a foxy branch from main before merging this PR.

robbel commented 3 years ago

Thanks @norro for the contributions, looks good to me. @gbiggs I created a foxy branch so merging this into main is fine.

gbiggs commented 3 years ago

@norro you need to GPG-sign your commits. Look at the GitHub documentation for how to generate a GPG key and tie it to your account. This gist has the command you need to sign commits you've already made.

norro commented 3 years ago

@gbiggs Oh, I see. I thought the weaker commit -s was enough. I will do so.

gbiggs commented 3 years ago

GPG signing is separate from DCO sign-off.