ros-safety / software_watchdogs

A library of (software) watchdogs based on DDS Quality of Service (QoS) policies and ROS 2 lifecycle nodes.
Apache License 2.0
71 stars 16 forks source link

Build failure since galactic due to missing default_value for period parameter #13

Open nlimpert opened 1 year ago

nlimpert commented 1 year ago

rclcpp API changes between foxy and galactic enforce the default_value for declare_parameter:

Hence starting with galactic the sw_watchdog package's simple_heartbeat node won't build as it does not set any default value.

I was going to fix this myself but saw that @jeskesen created a patch for this - @jeskesen would you mind creating a PR accordingly so we can discuss what's required to merge this?

Hommus commented 11 months ago

Keen to see this merged :+1:

vinnnyr commented 8 months ago

Coincidentally was blowing some dust off an old project and ran into the same thing. Implemented the same change as above and opened a PR.