Seperate Out Watchdog Msgs

ros-safety / software_watchdogs

A library of (software) watchdogs based on DDS Quality of Service (QoS) policies and ROS 2 lifecycle nodes.

Apache License 2.0

71 stars 17 forks source link

Closed vinnnyr closed 3 years ago

vinnnyr commented 3 years ago

Addresses #7

Separate out the sw_watchdog_msgs into it's own package so that these messages can be used in other packages

ROS2 Foxy
Ubuntu / POP OS 20.04
x86
ran all launch files
verified messages hsow up when invoking ros2 interface show
created a test package with a CMakeLists.txt that looks like this. The typesupport issue no longer occurs when using find_package() from an external package

Snippet of Test pkg CMakeLists

# find dependencies
find_package(ament_cmake REQUIRED)
find_package(sw_watchdog_msgs REQUIRED)

vinnnyr commented 3 years ago

Hi @togaen , can you please take another look?

togaen commented 3 years ago

@vinnnyr Yes, very sorry for the delay, I'll have a review done today.

togaen commented 3 years ago

@vinnnyr Are you able to turn on signed commits? We require those when merging code in. Otherwise, the PR looks good, thanks for contributing :-).

vinnnyr commented 3 years ago

Ok... looking into this. Will ping you here once I have figured it out. Thanks!

togaen commented 3 years ago

Ok... looking into this. Will ping you here once I have figured it out. Thanks!

Great. Let me know if you have difficulties; we'll get your changes in one way or another.

vinnnyr commented 3 years ago

@togaen Everything should be signed now, please check when you get a free chance. Thanks for looking over this and incorporating it.