search

ros-simulation / gazebo_ros_demos

Example robots and code for interfacing Gazebo with ROS
352 stars 226 forks source link

Fix xacro warning #18

Closed vincentrou closed 7 years ago

j-rivero commented 7 years ago

Thanks for the pull request Vincent. Which ROS platform did you use to test the change? Do we know if the change is supported in Indigo, Jade and Kinetic?

davetcoleman commented 7 years ago

+1

This is compatible with Jade and newer. Because this repo only has a master branch, I'm not sure if this will break Indigo but I doubt it.

vincentrou commented 7 years ago

Yes i only test it on kinetic.

Le 13 déc. 2016 1:26 AM, "Dave Coleman" notifications@github.com a écrit :

+1

This is compatible with Jade and newer. Because this repo only has a master branch, I'm not sure if this will break Indigo but I doubt it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-simulation/gazebo_ros_demos/pull/18#issuecomment-266597579, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4P-XsW9j8DuqQ0kk5vSXIs0_rYShB_ks5rHeZAgaJpZM4LKhqW .

davetcoleman commented 7 years ago

@j-rivero how about we branch this repo for Indigo/Kinetic?

j-rivero commented 7 years ago

@j-rivero how about we branch this repo for Indigo/Kinetic?

That makes sense to me. I'll do it after this PR.

This is compatible with Jade and newer. Because this repo only has a master branch, I'm not sure if this will break Indigo but I doubt it.

I just verified that the --inorder exists in Indigo so we can merge. Thanks Vincent!