search

ros-simulation / gazebo_ros_pkgs

Wrappers, tools and additional API's for using ROS with Gazebo
http://wiki.ros.org/gazebo_ros_pkgs
774 stars 772 forks source link

merge gazebo_ros_depth_camera and gazebo_ros_openni_kinect plugins and deprecate one of them #127

Open hsu opened 11 years ago

hsu commented 11 years ago

They started as dirty duplicate code, need to consolidate and deprecate one of them.

kev-the-dev commented 6 years ago

Still still needs to be done. These two plugins have diverged over the years causing many issues (and a lot of maintenance overhead).

My plan is to deprecate gazebo_ros_openni_kinect, having it just print a Deprecated warning then load the gazebo_ros_depth_camera plugin. It seems that the openni_kinect plugin is used more, because it is referenced in the tutorial, but the name is less accurate.

I'll also resolve the differences between the two, mostly bringing fixes from openni_kinect into depth_camera.

It should be possible to do this in a way that doesn't break API.