Closed vmayoral closed 4 years ago
ping @thomas-moulard
Reviewed and fixed the issue with the working directory (thanks @ruffsl :)!). @thomas-moulard could you please review it again?
I reproduced everything and there're some issues with the secure demos. See https://github.com/ros-swg/turtlebot3_demo/issues/29
Perhaps you'd like to rebase from https://github.com/ros-swg/turtlebot3_demo/pull/30 and test the rebuilt image again?
Rebased and retested. After merging #30 things fine to me @ruffsl.
@ruffsl, @mikaelarguedas and @thomas-moulard, PTAL. If everyone's fine with it, can you please merge this and I'll do yet another review on top of master?
This branch conflicts with master preventing me from rebasing it on top of master for testing. @vmayoral could you please update this branch with a rebased version of this PR ? thanks!
This branch conflicts with master preventing me from rebasing it on top of master for testing. @vmayoral could you please update this branch with a rebased version of this PR ? thanks!
Thanks for reviewing @mikaelarguedas. Interesting! I get the following which made me think that no conflicts applied
All right, let me rework this.
Add preliminar files for the reconnaissance demo tutorial.