Reconnaissance demo tutorial

ros-swg / turtlebot3_demo

Repository to build and test Turtlebot3 packages

Apache License 2.0

20 stars 6 forks source link

Reconnaissance demo tutorial #19

Closed vmayoral closed 4 years ago

vmayoral commented 4 years ago

Add preliminar files for the reconnaissance demo tutorial.

vmayoral commented 4 years ago

ping @thomas-moulard

vmayoral commented 4 years ago

Reviewed and fixed the issue with the working directory (thanks @ruffsl :)!). @thomas-moulard could you please review it again?

vmayoral commented 4 years ago

I reproduced everything and there're some issues with the secure demos. See https://github.com/ros-swg/turtlebot3_demo/issues/29

ruffsl commented 4 years ago

Perhaps you'd like to rebase from https://github.com/ros-swg/turtlebot3_demo/pull/30 and test the rebuilt image again?

vmayoral commented 4 years ago

Rebased and retested. After merging #30 things fine to me @ruffsl.

@ruffsl, @mikaelarguedas and @thomas-moulard, PTAL. If everyone's fine with it, can you please merge this and I'll do yet another review on top of master?

mikaelarguedas commented 4 years ago

This branch conflicts with master preventing me from rebasing it on top of master for testing. @vmayoral could you please update this branch with a rebased version of this PR ? thanks!

vmayoral commented 4 years ago

This branch conflicts with master preventing me from rebasing it on top of master for testing. @vmayoral could you please update this branch with a rebased version of this PR ? thanks!

Thanks for reviewing @mikaelarguedas. Interesting! I get the following which made me think that no conflicts applied

All right, let me rework this.

vmayoral commented 4 years ago

Follows at https://github.com/ros-swg/turtlebot3_demo/pull/31