ros-teleop / teleop_tools

A set of generic teleoperation tools for any robot.
183 stars 140 forks source link

Avoid halting on action server status checks. #48

Closed hidmic closed 4 years ago

hidmic commented 4 years ago

This pull requests prevents the joy_teleop node from halting 0.5 sec every 2 sec in search for "online" action servers.

bmagyar commented 4 years ago

@artivis

artivis commented 4 years ago

Couldn't test it however the change is rather small and makes sense (server_is_ready doc for reference). lgtm :+1:

hidmic commented 4 years ago

@artivis @bmagyar is this patch ready to go?

bmagyar commented 4 years ago

thanks for this, let's merge!