search

ros-teleop / teleop_twist_keyboard

Generic Keyboard Teleop for ROS
253 stars 399 forks source link

Added C++ implementation of teleop_twist_keyboard #14

Closed methylDragon closed 5 years ago

methylDragon commented 6 years ago

Very useful for interfacing with other C++ libraries (like DDS related ones!)

Original repo is here: https://github.com/methylDragon/teleop_twist_keyboard_cpp Docs: http://wiki.ros.org/teleop_twist_keyboard_cpp

Note: There's no support for ROS parameters or arguments from rosrun yet. I also changed how the reminder message gets sent and the speeds and turns are displayed to prevent too much printing.

-CH3EERS!

methylDragon commented 6 years ago

Spotted a typo with the move bindings, will push a fix soon

("u" and "," specifically)

Edit: Fixed!

trainman419 commented 5 years ago

Sorry for the delay in responding to this. I see this is one of your first pull requests and I wanted to provide a gentle response, but I haven't found a way to put this gently.

I think that adding a duplicate C++ implementation to the teleop_twist_keyboard package would be more confusing then helpful, particularly since the name is very similar but it provides a subtantially different user interface.

If you want to release this, you can easily do it from your own repository.

P.S. - if you want to provide this for other people to re-use the C++ code, you should probably package it as a library.

methylDragon commented 5 years ago

Alrighty! No worries, and thanks for the advice!