search

ros-teleop / teleop_twist_keyboard

Generic Keyboard Teleop for ROS
259 stars 405 forks source link

Added launch file, updated readme #3

Closed gallingern closed 8 years ago

trainman419 commented 9 years ago

Two comments:

  1. Please don't update the version number or the changelog. I will do that as part of the release process
  2. I don't see the need for a launch file.
trainman419 commented 9 years ago

Do you have any response to my comments?

If I haven't heard back within a week, I will close this PR.

gallingern commented 9 years ago

Sorry, didn't realize you were waiting for feedback.

  1. My bad. Wasn't sure the standard protocol.
  2. I find the launch file useful so I can launch teleop with a single command without having to worry about starting roscore. In retrospect, I realize that's a rare case.
trainman419 commented 8 years ago

Replaced by #5