search

ros-teleop / twist_mux

Twist multiplexer
Apache License 2.0
57 stars 86 forks source link

Added status topic to indicate which mux channel is selected and if l… #20

Open Michael-Equi opened 4 years ago

Michael-Equi commented 4 years ago

Added status topic to indicate which mux channel is selected and if lock is active

bmagyar commented 4 years ago

@Timple @doisyg could you guys please provide your review here, would this be useful to you too? Could you please also give it a test, I currently don't have a setup where I could properly test it

Timple commented 4 years ago

I don't have a need for this feature, but I'm willing to review.

Michael-Equi commented 4 years ago

Sorry I have not gotten back to this PR in a bit. Ill try to make some of the suggested modifications this weekend.

Timple commented 4 years ago

Ah, sorry. I've reviewed this a while back. But apparently you have to close the review in order for the comments to show up... I've hit publish now.

Main item: make the status a latched topic and you can drop the whole 'continuously' part.

chrisl8 commented 4 years ago

Any update on this? I'd like to use it. Thanks!

Timple commented 4 years ago

No updates, my last comment is still valid. Not sure if @Michael-Equi has any intention of implementing the latched topics. Feel free to implement that part yourself and open a seperate PR.

Michael-Equi commented 4 years ago

@chrisl8 Its not looking like I will have time to implement that anytime soon. I am also no longer using ROS1 as my team has fully transitioned our robot to ROS2 which makes it a bit harder to work on this.

chrisl8 commented 4 years ago

@Michael-Equi Which package, if any, are you using for command input mux on ROS2.

@Timple Sounds good. I'll give it a try soon if I can find time.