ros-teleop / twist_mux

Twist multiplexer
Apache License 2.0
57 stars 86 forks source link

joystick_relay.py likely not runnable on Noetic #22

Open sloretz opened 4 years ago

sloretz commented 4 years ago

@bmagyar FYI I noticed this while checking https://github.com/ros/rosdistro/pull/25265

It looks like joystick_relay.py will get installed with the wrong shebang on Noetic, and so it won't be runnable. See this ROS wiki page for more info: http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

To fix, the shebang should be changed to #!/usr/bin/env python

https://github.com/ros-teleop/twist_mux/blob/a2818fda98d68c80ec300f962013c98252c769e2/scripts/joystick_relay.py#L1

and the script should be installed with catkin_install_python()

https://github.com/ros-teleop/twist_mux/blob/a2818fda98d68c80ec300f962013c98252c769e2/CMakeLists.txt#L40-L41