search

ros-teleop / twist_mux

Twist multiplexer
Apache License 2.0
57 stars 86 forks source link

Windows build fixes #26

Closed Tobias-Fischer closed 3 years ago

bmagyar commented 3 years ago

Are you seeing an actual problem with this, e.g. a picky compiler, or it's personal preference?

Tobias-Fischer commented 3 years ago

I'm trying to compile this package on Windows for https://github.com/RoboStack/ros-noetic. I noticed that there are more non-standard usages, I'll fix it tomorrow and update the PR.

Tobias-Fischer commented 3 years ago

Okay, all issues are fixed now. twist-mux can now be compiled for Windows - see https://github.com/RoboStack/ros-noetic :)

bmagyar commented 3 years ago

Sad to see this tbh. These alternative operators are part of the standard, apparently not all compilers implement the full standard.

Tobias-Fischer commented 3 years ago

Thanks for merging! I didn't realize it's part of the standard. Potentially including iso646.h (https://docs.microsoft.com/en-us/cpp/c-runtime-library/iso646-operators?view=msvc-160) could have helped.