Closed emersonknapp closed 4 years ago
Merging #114 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 6 6
Lines 339 339
=======================================
Hits 292 292
Misses 47 47
Flag | Coverage Δ | |
---|---|---|
#unittests | 86.13% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dad484d...fb1f81b. Read the comment docs.
Ok, ran vale linter locally and removed the majority of the warnings, including all of the ones you brought up @thomas-moulard - will merge if all required checks pass
Closes #68
Followed through the steps step-by-step and verified that it works. This is the same process that is followed by the e2e tests, the only difference being path names.
Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com