ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Install linters exclusively via pip #117

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Fixes #109

In preparation for moving over to a pure-python package, this PR removes all rosdep dependency requirements.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

emersonknapp commented 4 years ago

There is an issue with the CI environment and the URL-based setuptools requirements - I am working on it and you can hold off reviewing until the checks are passing

codecov[bot] commented 4 years ago

Codecov Report

Merging #117 into master will decrease coverage by 1.65%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   87.36%   85.71%   -1.66%     
==========================================
  Files           6        9       +3     
  Lines         372      392      +20     
  Branches        0       23      +23     
==========================================
+ Hits          325      336      +11     
  Misses         47       47              
- Partials        0        9       +9
Flag Coverage Δ
#unittests 85.71% <ø> (-1.66%) :arrow_down:
Impacted Files Coverage Δ
test/test_colcon_mixins.py 88.23% <0%> (-5.89%) :arrow_down:
cross_compile/sysroot_compiler.py 77.09% <0%> (-3.92%) :arrow_down:
cross_compile/ros2_cross_compile.py 66.66% <0%> (-2.57%) :arrow_down:
test/test_flake8.py 100% <0%> (ø)
test/test_copyright.py 100% <0%> (ø)
test/test_pep257.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f952a22...cd892d4. Read the comment docs.

emersonknapp commented 4 years ago

Closing in favor of a more comprehensive switch to a non-ros package - which has a much simpler solution for this detail of it