search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Remove docker network config option #129

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

This feature has no clear use case and is not tested, so it shouldn't be here.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #129 into master will decrease coverage by 0.21%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   76.92%   76.71%   -0.22%     
==========================================
  Files           3        3              
  Lines         221      219       -2     
==========================================
- Hits          170      168       -2     
  Misses         51       51
Flag Coverage Δ
#unittests 76.71% <100%> (-0.22%) :arrow_down:
Impacted Files Coverage Δ
ros_cross_compile/ros_cross_compile.py 68.42% <ø> (-0.81%) :arrow_down:
ros_cross_compile/sysroot_compiler.py 80.68% <100%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3110752...d07cc35. Read the comment docs.