search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Codecov CI action fails on PRs from forks #132

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Description

When a Pull Request comes in from a fork, it can't access the secret codecov token, so the CI fails to upload codecov results and returns a failure. This was observed here: https://github.com/ros-tooling/cross_compile/pull/131

Latest news is that there is a GitHub Actions API released today, and the codecov action is working to implement a solution - see https://github.com/codecov/codecov-action/issues/29

For now, this issue can track that progress.

Expected Behavior

Actual Behavior

To Reproduce

System (please complete the following information)

N/A

Additional context

Codecov is working on "Tokenless uploads" https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/15

prajakta-gokhale commented 4 years ago

This is true for all repos using action-ros-ci. Similar issue: https://github.com/ros-tooling/action-ros-ci/issues/56.

emersonknapp commented 4 years ago

According to https://github.com/codecov/codecov-action/issues/29#issuecomment-589353189 we should have some option available in the next week or so.

emersonknapp commented 4 years ago

Codecov action "tokenless uploads" have been enabled - check if it works

emersonknapp commented 4 years ago

This is now working - see report on https://github.com/ros-tooling/cross_compile/pull/171 - accurately reported reduced coverage