ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Pull Platform out of SysrootCreator for reuse #138

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #138 into master will increase coverage by 1.4%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #138     +/-   ##
=========================================
+ Coverage   82.15%   83.56%   +1.4%     
=========================================
  Files           4        5      +1     
  Lines         213      213             
=========================================
+ Hits          175      178      +3     
+ Misses         38       35      -3
Flag Coverage Δ
#unittests 83.56% <92.85%> (+1.4%) :arrow_up:
Impacted Files Coverage Δ
ros_cross_compile/platform.py 100% <100%> (ø)
ros_cross_compile/sysroot_creator.py 86.6% <40%> (-2.71%) :arrow_down:
ros_cross_compile/ros_cross_compile.py 68.29% <80%> (+3.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8943e1a...b2b2af6. Read the comment docs.

emersonknapp commented 4 years ago

I made the types immutable via tuple instead of frozenset