Closed emersonknapp closed 4 years ago
Merging #143 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 6 6
Lines 225 225
=======================================
Hits 196 196
Misses 29 29
Flag | Coverage Δ | |
---|---|---|
#unittests | 87.11% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a7f38fa...2fe7ec3. Read the comment docs.
What is the reason behind making dummy_pkg
a ROS 2 package?
(Apologies if I'm missing context from earlier PRs)
Is your question "as opposed to a ROS 1 package"? - arbitrary choice, the bug here affects either version
Otherwise if question is "as opposed to what it currently was" - If you read my description for the PR, having it not be a ROS package was causing a breaking bug to successfully pass our e2e tests
Otherwise if question is "as opposed to what it currently was" - If you read my description for the PR, having it not be a ROS package was causing a breaking bug to successfully pass our e2e tests
Yes my question was "as opposed to what it previously was". It makes sense now, I see that it is made a ROS 2 package so that it always requires ros2
to be installed and sourced.
The outcome of last e2e test note:
I think I will split out 3 cases:
Seems like this will require more work, so I'm not reviewing it now. But your approach LGTM. Let's make sure we add plenty of comments around that rationale.
@thomas-moulard requesting re-review. I have updated with a ROS2 application and some documentation. This is a strict improvement over the current situation, and solves the identified bug for both ROS 1 and 2 workspaces, since the colcon setup.bash file is the same for either.
The
build_workspace.sh
script caused an error upon sourcingsetup.bash
because of unset variables, if ROS was actually installed.To fix:
set -u
option for that scriptAfter updating the package but before updating the script, the e2e test failed. Now it succeeds and is performing a more thorough test.
Part of the replacement for #139
Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com