search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Add shellcheck workflow to lint shell scripts #148

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #148 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files           6        6           
  Lines         225      225           
=======================================
  Hits          196      196           
  Misses         29       29
Flag Coverage Δ
#unittests 87.11% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb51278...f676e12. Read the comment docs.

thomas-moulard commented 4 years ago

Nice - could you demonstrate that this actually fail if you have a bug in a shell script? (e.g. open a draft PR with this + a linter issue, show that the new check actually fail)

emersonknapp commented 4 years ago

It's there in the commit history - https://github.com/ros-tooling/cross_compile/pull/148/checks?check_run_id=451846076 - you can see once I fixed the workflow syntax, the check failed because of a shellcheck complaint in build_workspace.sh, which I fixed in the next commit and it's green now.