search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Bump docker-py version to latest major #150

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

We were using a very old version and there's no reason to do so now that we're not dependent on rosdep

codecov[bot] commented 4 years ago

Codecov Report

Merging #150 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files           6        6           
  Lines         225      225           
=======================================
  Hits          196      196           
  Misses         29       29
Flag Coverage Δ
#unittests 87.11% <100.00%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4126f4b...1fc9592. Read the comment docs.

emersonknapp commented 4 years ago

Well, Ubuntu 20.04 Focal LTS will be out soon and it has version 4.x of this package. Foxy Fitzroy is also targeting Focal - I figure we don't plan to package for apt before the Foxy release, so we might as well consider that if we want to package for apt, we can do it for Focal and not Bionic

emersonknapp commented 4 years ago

Closing as we aim to support apt on Bionic until Dashing EOL, which rules out this PR as written. We will need to bump for release to apt on Focal, but we could potentially create a Bionic release branch for critical backports only, at that time.