search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Use no-install-recommends for all apt install commands #156

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

We were seeing some flakiness in the end-to-end tests, failing to install package humanity-icon-theme occasionally. This was being pulled in as a "recommended" apt package below colcon-common-extensions, but is not needed.

See example failure https://github.com/ros-tooling/cross_compile/pull/155/checks?check_run_id=466189777

This has the added benefit of shaving some time ~1-3mins off each e2e run, and ~150MB off of the default e2e test container.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files           6        6           
  Lines         225      225           
=======================================
  Hits          196      196           
  Misses         29       29
Flag Coverage Δ
#unittests 87.11% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f32ff53...a3ee5ce. Read the comment docs.