search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Raise exception when `docker run` fails #157

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Before this change, if a command run in a container failed, it would print the error but keep running onto the next step. This makes the command fail by not detaching the container.

It also introduces the command parameter for easier testing and extensibility.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #157 into master will increase coverage by 1.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   87.11%   88.39%   +1.28%     
==========================================
  Files           6        6              
  Lines         225      224       -1     
==========================================
+ Hits          196      198       +2     
+ Misses         29       26       -3
Flag Coverage Δ
#unittests 88.39% <100.00%> (+1.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4797e...505ba62. Read the comment docs.