Closed emersonknapp closed 4 years ago
Merging #161 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 7 7
Lines 259 259
=======================================
Hits 233 233
Misses 26 26
Flag | Coverage Δ | |
---|---|---|
#unittests | 89.96% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 00bcaa2...a334f20. Read the comment docs.
By removing the arguments and early-set environment variables, we increase docker cache reuse.
The long term goal is to store Docker images on a registry so users can pull rather than recreate common base images.
Removing these arguments and environment variables makes more of the base builder image common. Now the matrix is just [OS, arch].
Another benefit is that the arguments to the
build_workspace
script all must be provided by the caller, which makes everything a bit more explicit.