Closed emersonknapp closed 4 years ago
Merging #169 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 7 7
Lines 228 228
=======================================
Hits 214 214
Misses 14 14
Flag | Coverage Δ | |
---|---|---|
#unittests | 93.85% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1774a16...3319a40. Read the comment docs.
Does this behaviour need to be mentioned in the README?
We never mentioned it either way, and now that it builds an existing workspace like colcon does, this feels like a more intuitive behavior.
Remove reconfiguring/cleaning args from build mixin so that incremental builds can happen. A user who wants that level of clean can just remove the preexisting build/install directories before running the build.
Closes #108
Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com