search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Allow user to skip rosdep collection #177

Closed snehaldb90 closed 4 years ago

snehaldb90 commented 4 years ago

Resolves #140

Implemented a cross compile feature that allow user to skip ros dependencies.

codecov[bot] commented 4 years ago

Codecov Report

Merging #177 into master will increase coverage by 0.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   94.06%   94.28%   +0.21%     
==========================================
  Files           7        7              
  Lines         236      245       +9     
==========================================
+ Hits          222      231       +9     
  Misses         14       14
Flag Coverage Δ
#unittests 94.28% <100.00%> (+0.21%) :arrow_up:
Impacted Files Coverage Δ
ros_cross_compile/dependencies.py 100.00% <100.00%> (ø)
ros_cross_compile/ros_cross_compile.py 85.00% <100.00%> (+1.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fc6c4d...b250cd6. Read the comment docs.

emersonknapp commented 4 years ago

Before we merge this - Snehal, your git username and email are not configured - so the commits are "signed-off-by Ubuntu". This passes DCO because it's a simple check for the syntax, but it's not correct. Can you update the commit signoffs after updating your git config, then we can merge

thomas-moulard commented 4 years ago

+1 both the DCU, and the commit author needs an update.