ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Add documentation to test workflow for Docker fix #194

Closed zmichaels11 closed 4 years ago

zmichaels11 commented 4 years ago

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

thomas-moulard commented 4 years ago

This makes sense. I know this is outside the scope of this PR but I didn't review the other one: instead of hardcoding __w, we should try to use ${{ github.workspace }} as __w may change suddenly in the future. Doc is here: https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions look for github.workspace

zmichaels11 commented 4 years ago

@thomas-moulard I'll open up another PR for that change