ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Raise docker-py requirement to 4.x #259

Closed teodormadan closed 1 year ago

teodormadan commented 4 years ago

Signed-off-by: Teo Madan teodor.madan@nxp.com

teodormadan commented 4 years ago

Compatibility has been addressed with https://github.com/ros-tooling/cross_compile/pull/237/,

Still installing ros_cross_compile from source would bring older docker-py

teodormadan commented 4 years ago

Handled also the new BuildError 3.x docker API according to detected docker version, and remove the old test for BuildError api as not applicable.

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.01% // Head: 93.01% // No change to project coverage :thumbsup:

Coverage data is based on head (8943011) compared to base (8943011). Patch has no changes to coverable lines.

:exclamation: Current head 8943011 differs from pull request most recent head bf65f50. Consider uploading reports for the commit bf65f50 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #259 +/- ## ======================================= Coverage 93.01% 93.01% ======================================= Files 10 10 Lines 415 415 ======================================= Hits 386 386 Misses 29 29 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `93.01% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MichaelOrlov commented 1 year ago