ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

chown build outputs even if build fails #275

Closed emersonknapp closed 3 years ago

emersonknapp commented 3 years ago

Fixes #153 Depends on #276

Use an exit hook in the bash building script to make sure that everything in the workspace is owned by the calling user, rather than by root. Add a test that fails before the change

codecov[bot] commented 3 years ago

Codecov Report

Merging #275 (475d7b4) into master (5efbbed) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          10       10           
  Lines         404      404           
=======================================
  Hits          372      372           
  Misses         32       32           
Flag Coverage Δ
unittests 92.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5efbbed...475d7b4. Read the comment docs.

emersonknapp commented 3 years ago

@zmichaels11 almost all of the change is testing framework - I am introducing a pytest-based test for building, which didn't exist previously, so that looks like a lot of test code.

Adding this new test type highlighted that the "docker-in-docker" builds that we had been doing for the pytests were not able to do emulation, whereas the setup that "e2e" was using could do qemu emulation just fine - so I consolidated the setup between the two - I am going to move in the direction of removing that e2e script and making it all into python-based tests instead of an unwieldy bash script

emersonknapp commented 3 years ago

Ok - talked myself out of this larger PR, https://github.com/ros-tooling/cross_compile/pull/276 will come first and enable this, making the actual bugfix a lot more obvious